fix(runtime) support snapshot testing #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracking the unfortunate dependency on babel here #40 |
sam-goodwin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #35
Assume we are running as a unit test when
process.mainModuleisundefined. This case happens when the node application is not invoked directly withnode, usually when the app is loaded from a unit test. Luckily, the CDK invokes the app as an ordinary node process.This change unblocks snapshot testing - so I also added snapshot tests to detect regressions in the CloudFormation stacks of the example apps.
Would still like to find a better solution.